Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versioneer for python 3.12 compatibility #51

Closed
wants to merge 1 commit into from

Conversation

DanGonite57
Copy link
Contributor

Fixes #50

@dvzrv
Copy link

dvzrv commented Apr 5, 2024

@vpelletier can this please be merged and released?
We are currently hitting this issue while rebuilding the distro against python 3.12 on Arch Linux

@vpelletier
Copy link
Owner

Thank you for the heads-up.

On a higher level, I am getting really annoyed with versioneer: I still like it as a feature, but I believe this is the 3rd time since I use it, and the second time in the two latest minor cpython versions, that versioneer is what is breaking compatibility, requiring the update of every repository where I use it.

Then there is also the perspective from the xz debacle, which, to me, also highlights how bundling files coming from 3rd-party projects (autogen in the case of xz) can be used to rope in obfuscated backdoors (and otherwise hostile code), which makes me even less happy with versioneer dropping anything but absolutely trivial files in the repository.

Overall, I think I would rather get rid of it (or otherwise push it outside of the repository) rather than keep chasing its latest version.

And on top of all this, I currently have very little spare time (and will not have for a few more months at least), which is not helping me in figuring out what other way I am more comfortable with. Pointers are welcome.

In the meantime, for distribution packaging purposes, are you able/is it a good idea to have you apply the present patch during packaging ?

ekiefl added a commit to ekiefl/pooltool that referenced this pull request Jul 26, 2024
- pprofile can be patched in if/when this merges:
  vpelletier/pprofile#51
@ekiefl
Copy link

ekiefl commented Jul 28, 2024

I'm sad that I have to let pprofile loose from my package because of this. Thank you sincerely for the otherwise amazing project, I've used it happily for years.

@vpelletier
Copy link
Owner

Spare time is slowly becoming a thing again, so I'm finally back on this topic.

Is there a reason the version bump is only to 0.19, as opposed to jumping directly to now-current 0.29 ?

@DanGonite57
Copy link
Contributor Author

I wanted to try to let you keep compatibility with as many versions of python 3 as possible, so I just went with the earliest compatible version. Otherwise, I don't remember encountering any particular issues when testing with versioneer 0.29 either.

(https://github.com/DanGonite57/pprofile/commits/test312/)

@vpelletier
Copy link
Owner

Mmh, looks like github failed to recognise that I rebased & merged this change from the command line. So I am closing this, but the change is now in master - and now to be released as 2.2.0 .

Sorry for the time it took for me to act on this.

@vpelletier vpelletier closed this Sep 6, 2024
@ekiefl
Copy link

ekiefl commented Sep 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioneer 0.18 incompatible with Python 3.12
4 participants